OCM-7268 | feat: Update create machinepool command to support kubeletconfigs #2045
Conversation
openshift-ci
bot
added
the
approved
| @@ -386,6 +386,44 @@ func addNodePool(cmd *cobra.Command, clusterKey string, cluster *cmv1.Cluster, r | |||
| npBuilder.TuningConfigs(inputTuningConfig...) | |||
| } | |||
|
|
|||
| var inputKubeletConfigs []string | |||
There was a problem hiding this comment.
We have an active task on-going to refactor the create machinepool command to align with the runner model. I'm following the existing implementation at the minute to avoid do a large refactor in this PR.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2045 +/- ##
==========================================
- Coverage 25.13% 24.78% -0.35%
==========================================
Files 148 148
Lines 21841 22338 +497
==========================================
+ Hits 5489 5537 +48
- Misses 15934 16382 +448
- Partials 418 419 +1 ☔ View full report in Codecov by Sentry. |
robpblake
force-pushed
the
ocm-7268-create-machinepool
branch
from
f059d0d
to
65c4c3f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciaranRoche, robpblake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@robpblake: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR updates the
rosa create machinepoolcommand with support for the--kubelet-configsoption, that allows the user to specify a list of KubeletConfignameto attach to a specific HCP MachinePool.